search

MichaCo / CacheManager

CacheManager is an open source caching abstraction layer for .NET written in C#. It supports various cache providers and implements many advanced features.
http://cachemanager.michaco.net
Apache License 2.0
2.33k stars 457 forks source link

Updated StackExchange.Redis library version #337

Closed borgmatthew closed 3 years ago

MichaCo commented 3 years ago

Hi @borgmatthew , thanks for the PR

Why did you make the changes in RedisValueConverter?

borgmatthew commented 3 years ago

@MichaCo the changes in RedisValueConverter were required for the project to compile. Casting was required as the references were ambiguous. I am attempting to update to the latest Redis client version, which is 2.2.4.

borgmatthew commented 3 years ago

@MichaCo Updated to the latest version of the StackExchange.Redis library

MichaCo commented 3 years ago

Could you undo the icon thing and any changes to the test project? <PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="5.0.0" />

I actually just did similar changes, but I can merge your. Just for those 2 thing I got more/different updates. I also just did the update to the latest redis version, didn't remember that there was a PR ^^ But I'd merge your changes then anyways

borgmatthew commented 3 years ago

@MichaCo No worries, this can be closed then. Please note that there is a newer version of StackExchange.Redis, which is version 2.2.62

MichaCo commented 3 years ago

ok