search

MichaCo / DnsClient.NET

DnsClient.NET is a simple yet very powerful and high performant open source library for the .NET Framework to do DNS lookups
https://dnsclient.michaco.net
Apache License 2.0
781 stars 137 forks source link

PR for Duplicated UDP responses from DNS confuse LookupClient #140 #142

Closed JamesKovacs closed 2 years ago

JamesKovacs commented 2 years ago

The following PR is to resolve the issue reported in #140.

MichaCo commented 2 years ago

Hi @JamesKovacs I think the implementation itself looks reasonable (will review it a bit more now)

The unit test, especially Lookup_XidMismatch seems a bit flaky though: The 2 tests with mismatchResponses = 10 fail for me locally all the time.

JamesKovacs commented 2 years ago

Thanks for the feedback. I've addressed your comments and will push another commit to the branch shortly.

JamesKovacs commented 2 years ago

Changes pushed and ready for review. Thanks again!

MichaCo commented 2 years ago

The tests failed during build. I'll fix that later, seems not really related to your changes. I have to finish one more change and then planning to release this end of the week I think.

Thanks again for your help!

djj0809 commented 2 years ago

@MichaCo Looking forward to the new version.

We have been seeing DNS resolution failure in one of our cluster from time to time but was not able to identity the root cause, thanks @JamesKovacs !