MichaIng / DietPi-Docs

Source repository for the DietPi OS documentation
https://dietpi.com/docs/
Creative Commons Attribution Share Alike 4.0 International
163 stars 51 forks source link

update contribution guidelines for docs #467

Open CouldBeThis opened 3 years ago

CouldBeThis commented 3 years ago

little weirdies

I actually started this a bit already. (Those who can't do, teach.)

**

Am not sure exactly where it might live. On repos' readmes there are https://github.com/MichaIng/DietPi#contributing and https://github.com/MichaIng/DietPi-Docs#contributing A separate file might be better? Some of it might be useful to the rest of the project but mostly it would be too basic.

please add

I will add as I come across things.

MichaIng commented 3 years ago

Many thanks for your suggestions.

Good points. It makes sense to make clear on each repository what it is for, and add that to our contribution page and/or the docs.

As for the linter, when cloning the repo within GitHub, one just needs to enable GitHub actions for the own repo (I think that is not the case by default). Since the actions config is part of the repo, it should then run automatically on each commit: https://github.com/MichaIng/DietPi-Docs/blob/master/.github/workflows/actions.yml

That is not true for CodeFactor checks, which is an app that requires an account. But we might convert that into GitHub actions as well, to have everything in one place.

StephanStS commented 3 years ago

Regarding the linter (Markdown checker)

What should I do before issueing a PR? If you generate an own branch for developing DietPi-Docs you are able to run the checks before issueing the PR. Just push your changes to your (private) branch and then go to the "actions" tab:

grafik

Then, select the "..." and "View workflow file" which belongs to your push operation:

grafik

Then, click on "Actions" and examine the output of the checks:

grafik

Remarks:

StephanStS commented 3 years ago

Regarding editing Markdown

Here we may collect some useful hints for editing the Markdown files.

Admonitions

If you want to use admonitions: See mkdocs reference.
Examples for admonitions (in file https://dietpi.com/docs/install):

grafik

Keyboard keys

If you want to use keyboard keys, see PyMdown Extension docu and mkdocs reference.
Examples for keys (in file https://dietpi.com/docs/dietpi_tools/):

grafik