DietPi-Software | Flagged for removal (cleanup)

MichaIng / DietPi

Lightweight justice for your single-board computer!

https://dietpi.com/

GNU General Public License v2.0

4.9k stars 499 forks source link

DietPi-Software | Flagged for removal (cleanup) #1491

Closed Fourdee closed 6 years ago

Fourdee commented 6 years ago

Goal is to remove the following items:

Outdated/no longer developed software titles (eg: raspcontrol https://github.com/Fourdee/DietPi/issues/1485#issuecomment-364168459)
Low install count from our users
Allow us to focus support on more popular software titles

Fourdee commented 6 years ago

🈯️ Removed: Grasshopper [100] | 1 install | no longer developed
🈯️ Removed: Raspcontrol [106] | 9 installs | no longer developed, non-functional: https://github.com/Fourdee/DietPi/issues/1485#issuecomment-364168459

Fourdee commented 6 years ago

@k-plan @MichaIng

Any suggestions we can add to the above list?

MichaIng commented 6 years ago

@Fourdee

SubSonic 5, but add LibreSonic instead as at least until last summer developed: https://github.com/Fourdee/DietPi/issues/330#issuecomment-358902464
- Ahh wait, better take AirSonic, the next fork 😆: https://github.com/airsonic/airsonic
- How are the installed numbers of SubSonic 5 and 6 actually? We have other web stream alternatives anyway.
Grashopper might be installed by me due to testing. as I not always remember to opt out dietpi-survey 😜. Maybe we can auto opt out on dietpi-update, if any other than master branch is used 🤔.

If software indexes are freed, how did you handle them in the past? Switch others software indexes? As gaps will cause dietpi-software to fail (the reason I left MySQL+Stacks dummy declarations). Maybe we can simple include a check for existing aSOFTWARE_WHIP_NAME[$i].

Fourdee commented 6 years ago

@MichaIng

If software indexes are freed, how did you handle them in the past? Switch others software indexes?

For quickness:

Set aSOFTWARE_TYPE[$index_current]=-1, hides from the GUI.
Make a note of it being disabled, so it can be reused at a later date.
Remove the install/config/uninstall code

If time permits:

manually swap the highest software index in the install/config/uninstall code.

Fourdee commented 6 years ago

@MichaIng I'll send a commit for example https://github.com/Fourdee/DietPi/commit/d6330ed2681dc8ad0796028ee72834b7ff40de30

MichaIng commented 6 years ago

@Fourdee Okay, maybe I find the time to fill the MySQL indexes gaps. But one has to patch the existing .installed state on update as well.

Fourdee commented 6 years ago

@MichaIng

But one has to patch the existing .installed state on update as well.

Yep 👍

For this example, we can simply reset [100]=0, as PiJuice is not available v6.1. And it only effects 1 user (you) hehe 😃

Fourdee commented 6 years ago

Marking as closed. Raspcontrol/Grasshopper only for now.