DietPi-Set_Hardware | Compiling "i-sable-2km" module fails

klasLiesen commented 5 years ago

I get error 2 and 'all' failed when selecting/installing soundcard i-sabre-2km in Dietpi-config. Had no problems prior to Dietpi 6.20.

skarmavbild 5

MichaIng commented 5 years ago

@klasLiesen Thanks for your report.

The headers does not seem to be installed, which is strange according to the code as you should have received an error message about that before.

Please check:

uname -r # Your active kernel is indeed 4.14.79, which is current repo version since last November so should be
dpkg -l | grep raspberrypi-kernel # Kernel headers are installed and match the kernel version

klasLiesen commented 5 years ago

Thanks for your response.

Here is the result plus installation progress of the soundcard.

skarmavbild 8

Sparade Terminal-utmatningar.txt

MichaIng commented 5 years ago

@klasLiesen Everything as intended. Please check:

ls -l /lib/modules/4.14.79-v7+/ # Should contain the "source" dir
dpkg -S /lib/modules/4.14.79-v7+/source # Should list "raspberrypi-kernel-headers" as provider of this dir

If somehow this is not the case, please try to reinstall the kernel headers: apt reinstall raspberrypi-kernel-headers

Otherwise I am a bid lost, since this worked well during tests. Perhaps the sources dir the Makefile expects needs to be changed, although very unlikely: KERNEL_SRC = /lib/modules/$(shell uname -r)/source => KERNEL_SRC = /lib/modules/$(shell uname -r)/build

klasLiesen commented 5 years ago

I get this when trying the commands.

I have no problems with other soundcards, only the Sabre.

skarmavbild 11

skarmavbild 13

If we can't solv this, is it possible to get a download link to the last dist of DietPi prior to 6.20?

Thank for your help. Hope you will find a way to help me with this.

/Klas

MichaIng commented 5 years ago

Ah sorry the APT reinstall command is: apt install --reinstall raspberrypi-kernel-headers

Other sound cards work fine, since their kernel modules/drivers are already included in the default Raspberry Pi kernel, so no module build required.

Okay I will check/verify this on my RPi later. In worst case you need to go the way with rpi-source which worked previously. However the APT package should render this obsolete, e.g. WireGuard module build works with the package as will without issues.

klasLiesen commented 5 years ago

Reinstall now worked fine but still no luck with the Sabre card i'm afraid.

/Klas

skarmavbild 14

MichaIng commented 5 years ago

Okay, please try the following to switch the source dir, according to most guides this should be /lib/modules/$(uname -r)/build instead of /lib/modules/$(uname -r)/source. Simply create a symlink to redirect to the correct source dir: ln -s /lib/modules/$(uname -r)/build /lib/modules/$(uname -r)/source

If this works we need to commit to the module dev to switch this in the Makefile to match current raspberrypi-kernel-headers file structure.

klasLiesen commented 5 years ago

Didn't work all the way.

/Klas

skarmavbild 15

MichaIng commented 5 years ago

@klasLiesen gcc: Command not found

Do: G_AGI g++-4.9

The symlink build => source btw. is correct. rpi-source does the same, respectively links to both from the same /usr/src/linux-headers-* dir: https://github.com/notro/rpi-source/blob/master/rpi-source#L340-L341

Dev notes:

The gcc version need to match the one from:

2019-02-15 00:05:40 root@micha:/tmp# cat /proc/version
Linux version 4.14.79-v7+ (dc4@dc4-XPS13-9333) (gcc version 4.9.3 (crosstool-NG crosstool-ng-1.22.0-88-g8460611)) #1159 SMP Sun Nov 4 17:50:20 GMT 2018

So 4.9.3 currently. This should be the one provided by Raspbian Stretch repo, but e.g. on Buster gcc/g++-4.9 installs v4.9.4 which means Buster breaks this build until the raspberrypi.org repo is ported to Buster, I guess, where for sure the kernel will be build on 4.9.4 or hopefully modern e.g. v8 already.
rpi-source does this check and reports error on mismatch (https://github.com/notro/rpi-source/blob/master/rpi-source#L174-L196), but raspberrypi-kernel-headers does not include the c compiler.
Ref: https://github.com/SatoruKawase/I-Sabre-K2M/blob/master/INSTALL.md
Deps: device-tree-compiler <<< libraspberrypi-bin and gcc-4.9 <<< g++-4,9

MichaIng commented 5 years ago

PR up to fix and add infos: https://github.com/Fourdee/DietPi/pull/2550

klasLiesen commented 5 years ago

Good morning Michalng. This time I get this response.

 ────────────────────────────────────────────────
 DietPi | Fri 15/02/19 - 07:06
 ────────────────────────────────────────────────
 v6.21.1 | RPi 3 Model B (armv7l)
 ────────────────────────────────────────────────
 eth0 | 192.168.1.211
 ────────────────────────────────────────────────
 DietPi Team     : Daniel Knight (founder), MichaIng, K-Plan
 Image           : DietPi Core Team (pre-image: Raspbian Lite)
 Web             : https://DietPi.com | https://twitter.com/dietpi_
 Patreon Legends : PINE64 community
 Donate          : https://DietPi.com/#donate
 DietPi Hosting  : Powered by https://MyVirtualServer.com

 dietpi-launcher  = All the DietPi programs in one place.
 dietpi-config    = Feature rich configuration tool for your device.
 dietpi-software  = Select optimized software for installation.
 htop             = Resource monitor.
 cpu              = Shows CPU information and stats.

root@DietPi:~# G_AGI g++-4.9
[  OK  ] Root access verified.
[  OK  ] APT installation for: g++-4.9, please wait...
Selecting previously unselected package libmpfr4:armhf.
(Reading database ... 49759 files and directories currently installed.)
Preparing to unpack .../00-libmpfr4_3.1.5-1_armhf.deb ...
Unpacking libmpfr4:armhf (3.1.5-1) ...
Selecting previously unselected package libmpc3:armhf.
Preparing to unpack .../01-libmpc3_1.0.3-1_armhf.deb ...
Unpacking libmpc3:armhf (1.0.3-1) ...
Selecting previously unselected package binutils.
Preparing to unpack .../02-binutils_2.28-5_armhf.deb ...
Unpacking binutils (2.28-5) ...
Selecting previously unselected package cpp-4.9.
Preparing to unpack .../03-cpp-4.9_4.9.3-14_armhf.deb ...
Unpacking cpp-4.9 (4.9.3-14) ...
Selecting previously unselected package libatomic1:armhf.
Preparing to unpack .../04-libatomic1_6.3.0-18+rpi1+deb9u1_armhf.deb ...
Unpacking libatomic1:armhf (6.3.0-18+rpi1+deb9u1) ...
Selecting previously unselected package libasan1:armhf.
Preparing to unpack .../05-libasan1_4.9.3-14_armhf.deb ...
Unpacking libasan1:armhf (4.9.3-14) ...
Selecting previously unselected package libubsan0:armhf.
Preparing to unpack .../06-libubsan0_6.3.0-18+rpi1+deb9u1_armhf.deb ...
Unpacking libubsan0:armhf (6.3.0-18+rpi1+deb9u1) ...
Selecting previously unselected package libgcc-4.9-dev:armhf.
Preparing to unpack .../07-libgcc-4.9-dev_4.9.3-14_armhf.deb ...
Unpacking libgcc-4.9-dev:armhf (4.9.3-14) ...
Selecting previously unselected package gcc-4.9.
Preparing to unpack .../08-gcc-4.9_4.9.3-14_armhf.deb ...
Unpacking gcc-4.9 (4.9.3-14) ...
Selecting previously unselected package libc-dev-bin.
Preparing to unpack .../09-libc-dev-bin_2.24-11+deb9u3_armhf.deb ...
Unpacking libc-dev-bin (2.24-11+deb9u3) ...
Selecting previously unselected package linux-libc-dev:armhf.
Preparing to unpack .../10-linux-libc-dev_4.9.82-1+deb9u3+rpi1_armhf.deb ...
Unpacking linux-libc-dev:armhf (4.9.82-1+deb9u3+rpi1) ...
Selecting previously unselected package libc6-dev:armhf.
Preparing to unpack .../11-libc6-dev_2.24-11+deb9u3_armhf.deb ...
Unpacking libc6-dev:armhf (2.24-11+deb9u3) ...
Selecting previously unselected package libstdc++-4.9-dev:armhf.
Preparing to unpack .../12-libstdc++-4.9-dev_4.9.3-14_armhf.deb ...
Unpacking libstdc++-4.9-dev:armhf (4.9.3-14) ...
Selecting previously unselected package g++-4.9.
Preparing to unpack .../13-g++-4.9_4.9.3-14_armhf.deb ...
Unpacking g++-4.9 (4.9.3-14) ...
Setting up libatomic1:armhf (6.3.0-18+rpi1+deb9u1) ...
Setting up libubsan0:armhf (6.3.0-18+rpi1+deb9u1) ...
Setting up linux-libc-dev:armhf (4.9.82-1+deb9u3+rpi1) ...
Processing triggers for libc-bin (2.24-11+deb9u3) ...
Setting up libasan1:armhf (4.9.3-14) ...
Setting up libgcc-4.9-dev:armhf (4.9.3-14) ...
Setting up libmpfr4:armhf (3.1.5-1) ...
 ────────────────────────────────────────────────
[ SUB1 ] DietPi-Set_Hardware > soundcard (i-sabre-k2m)
[  OK  ] DietPi-Set_Hardware | Checking for pre-req APT packages: alsa-utils
[ INFO ] DietPi-Set_Hardware | Pre-req APT packages are installed
[  OK  ] DietPi-Set_Hardware | Setting in /DietPi/config.txt adjusted: dtparam=audio=off
[  OK  ] DietPi-Set_Hardware | Desired setting in /DietPi/dietpi.txt was already set: CONFIG_SOUNDCARD=i-sabre-k2m
[  OK  ] DietPi-Set_Hardware | Setting in /DietPi/config.txt adjusted: dtparam=audio=on
[  OK  ] DietPi-Set_Hardware | APT update, please wait...
Get:1 http://raspbian.raspberrypi.org/raspbian stretch InRelease [15.0 kB]
Hit:2 https://archive.raspberrypi.org/debian stretch InRelease
Fetched 15.0 kB in 1s (7,545 B/s)
Reading package lists...

[  OK  ] DietPi-Set_Hardware | G_AGUP
[  OK  ] DietPi-Set_Hardware | APT installation for: raspberrypi-bootloader raspberrypi-kernel libraspberrypi-bin libraspberrypi0 raspberrypi-kernel-headers make, please wait...

[  OK  ] DietPi-Set_Hardware | G_AGI: raspberrypi-bootloader raspberrypi-kernel libraspberrypi-bin libraspberrypi0 raspberrypi-kernel-headers make
raspberrypi-bootloader was already not hold.
raspberrypi-kernel was already not hold.
libraspberrypi-bin was already not hold.
libraspberrypi0 was already not hold.
[  OK  ] DietPi-Set_Hardware | Connection test: https://dietpi.com/downloads/sourcebuild/I-Sabre-K2M.7z
--2019-02-15 07:07:53--  https://dietpi.com/downloads/sourcebuild/I-Sabre-K2M.7z
Resolving dietpi.com (dietpi.com)... 104.27.178.199, 104.27.179.199, 2606:4700:30::681b:b3c7, ...
Connecting to dietpi.com (dietpi.com)|104.27.178.199|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 5511 (5.4K) [application/x-7z-compressed]
Saving to: ‘package.7z’

package.7z          100%[===================>]   5.38K  --.-KB/s    in 0.001s  

2019-02-15 07:07:53 (7.85 MB/s) - ‘package.7z’ saved [5511/5511]

7-Zip [32] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21
p7zip Version 16.02 (locale=en_GB.UTF-8,Utf16=on,HugeFiles=on,32 bits,4 CPUs LE)

Scanning the drive for archives:
1 file, 5511 bytes (6 KiB)

Extracting archive: package.7z
--
Path = package.7z
Type = 7z
Physical Size = 5511
Headers Size = 291
Method = LZMA2:24k
Solid = +
Blocks = 1

Everything is Ok

Files: 7
Size:       20187
Compressed: 5511
[FAILED] DietPi-Set_Hardware | make

─────────────────────────┤ DietPi Error Handler: ├──────────────────────────────
tPi-Set_Hardware: make
Exit code: 2
DietPi version: v6.21.1 (Fourdee/master) | HW_MODEL:3 | HW_ARCH:2 | DISTRO:4
Image creator: DietPi Core Team
Pre-image: Raspbian Lite

 file contents:
e -C /lib/modules/4.14.79-v7+/source
DIRS=/tmp/DietPi-Set_Hardware/i-sabre-k2m_build KBUILD_VERBOSE=0 modules
e[1]: Entering directory '/usr/src/linux-headers-4.14.79-v7+'
cripts/gcc-version.sh: line 26: gcc: command not found
cripts/gcc-version.sh: line 27: gcc: command not found
e[1]: gcc: Command not found
e[1]: gcc: Command not found
e[1]: gcc: Command not found
e[1]: gcc: Command not found

                   Retry : Re-run the last command that failed

                    <Ok>                            <Exit>

────────────────────────────────────────────────────────────────────────────────

MichaIng commented 5 years ago

Hmm:

Selecting previously unselected package gcc-4.9.
Preparing to unpack .../08-gcc-4.9_4.9.3-14_armhf.deb ...
Unpacking gcc-4.9 (4.9.3-14) ...

So gcc is installed, and the correct version as expected.

But again make reports:

Entering directory '/usr/src/linux-headers-4.14.79-v7+'
$cripts/gcc-version.sh: line 26: gcc: command not found

Works well here (x86 VM):

root@VM-Stretch:/lib/modules/4.9.0-8-amd64/source/scripts# ./gcc-version.sh gcc
0603

@klasLiesen Thanks for testing.

What do those say:

command -v gcc
gcc --version

@Fourdee Looks like we missed testing this and rpi-source indeed includes some checks and steps that are missing when installing the raspberrypi-kernel-headers. While not required for WireGuard obviously, here it is.

While I definitely don't want to revert to rpi-source method (even it's dev renders it obsolete and only useful as companion to rpi-update for testing/dev reasons), but we need to figure out the missing steps here and remember for other module builds as well. At least the gcc/g++ 4.9 install is very common for this kernel and I wonder why it is not a dependency of the header package. Same for the ../source => ../build symlink 🤔. On x86 both is available, pointing to different directories, where on RPi this is merged, but obviously module Makefiles can expect both...

klasLiesen commented 5 years ago

Hope this is what you need. /Klas skarmavbild 16

MichaIng commented 5 years ago

Just checked, indeed gcc binary to version link is not created automatically .... 🙄:

...
Setting up gcc-6 (6.3.0-18+deb9u1) ...
Processing triggers for libc-bin (2.24-11+deb9u3) ...
root@VM-Stretch:~# which gcc
root@VM-Stretch:~# which gcc-6
/usr/bin/gcc-6

On RPi, the package contains:

2019-02-15 14:26:55 root@micha:/tmp# dpkg-deb -c gcc-4.9_4.9.4-2+rpi1+b19_armhf.deb
drwxr-xr-x root/root         0 2018-02-08 01:59 ./
drwxr-xr-x root/root         0 2018-02-08 01:59 ./usr/
drwxr-xr-x root/root         0 2018-02-08 01:59 ./usr/bin/
-rwxr-xr-x root/root    667784 2018-02-08 01:59 ./usr/bin/gcc-4.9
-rwxr-xr-x root/root     26348 2018-02-08 01:59 ./usr/bin/gcc-ar-4.9
-rwxr-xr-x root/root     26348 2018-02-08 01:59 ./usr/bin/gcc-nm-4.9
-rwxr-xr-x root/root     26348 2018-02-08 01:59 ./usr/bin/gcc-ranlib-4.9
-rwxr-xr-x root/root    371284 2018-02-08 01:59 ./usr/bin/gcov-4.9
drwxr-xr-x root/root         0 2018-02-08 01:59 ./usr/lib/
...

@klasLiesen So do: ln -s /usr/bin/gcc-4.9 /usr/bin/gcc And to be failsafe as well: ln -s /usr/bin/g++-4.9 /usr/bin/g++

To check:

Is there a way to force a specific gcc binary for the make command?
Because the above would not work or break other gcc versions, if installed...
Perhaps we should do the same with g++? Although I don't see where this is actually used...

klasLiesen commented 5 years ago

We have a success.

I used: ln -s /usr/bin/gcc-4.9 /usr/bin/gcc

and then selected/installed soundcard i-sabre-2km in Dietpi-config.

Should I do: ln -s /usr/bin/g++-4.9 /usr/bin/g++ as well? /Klas

skarmavbild 18

MichaIng commented 5 years ago

@klasLiesen Great finally 😅.

Nope g++ is not required then. All this was only to build the kernel module and this has obviously finished successfully.

Hmm even the official docs state to install g++ as well, it indeed seems not to be required. However this is something we can test ourself to fine tune the install/build script.

As well we can test if make CC=gcc-4.9 is sufficient to not mess with possibly already installed different gcc versions.

@Fourdee Might you find some time to test the above (also mentioned within the open PR)?

klasLiesen commented 5 years ago

I tried: ln -s /usr/bin/g++-4.9 /usr/bin/g++ and selected/installed soundcard i-sabre-2km in Dietpi-config. I got no complains but the soundcard did not show in Roon.

I then: apt install --reinstall raspberrypi-kernel-headers G_AGI g++-4.9 ln -s /usr/bin/gcc-4.9 /usr/bin/gcc and selected/installed soundcard i-sabre-2km in Dietpi-config. (Don't know if that's the right way to do it) Soundcard was back in Roon and music is playing.

Thanks for all help and have a nice weekend.

Klas

MichaIng commented 5 years ago

@klasLiesen Jep ln -s /usr/bin/gcc-4.9 /usr/bin/gcc or giving this information inside the code to the make command is definitely required. The g++ binary obviously doesn't play a role here, also I couldn't find any g++ calls within the scripts in the kernel source so far...

MichaIng / DietPi

DietPi-Set_Hardware | Compiling "i-sable-2km" module fails #2547