MichaIng / DietPi

Lightweight justice for your single-board computer!
https://dietpi.com/
GNU General Public License v2.0
4.85k stars 495 forks source link

DietPi-Globals | whiptail has no scrollbar #2947

Open MichaIng opened 5 years ago

MichaIng commented 5 years ago

This is an old issue, but I just fell over this again. I actually wanted to automatically add a scrollbar to G_WHIP_MSG if text is too long to fit on the screen. By this we could remove G_WHIP_SCROLLBOX and rely on the anyway made Y size estimation.

Strange is now, that the scrollbars do not appear with the --scrolltext flag. It took me a while to find out why some manual whiptail test succeed with this while G_WHIP does not. The reason is that the scrollbar starts AFTER the text. So if the text fills the whole whiptail y size, the scrollbars are completely hidden: whiptail

This is odd, since the scrollbar does not have any point, if the text does not fill the whole whiptail, as then there is nothing to scroll 😕. I am totally confused now as this feature has no point at all then, but can't believe that this has never been fixed for several years. EDIT: Without --scrolltext, scrolling is not possible at all, hence the functional part of the feature works, but the visual part (scroll bars) not as intended.

If I oversee something, please give me a hint, otherwise we can remove G_WHIP_SCROLLBOX anyway and should better report this bug to the maintainer, if not already done for a long time. But couldn't find it at least on quick search.

Same on Buster btw...

MichaIng commented 4 years ago

Seems to have worked well back in end of 2017, not sure which distro (bottom of page): https://www.krazyworks.com/whiptail-and-dialog-snippets/

Same error reported here little earlier: https://stackoverflow.com/a/46146021 Probably not whiptail bug but newt bug.

Strange that this is so rarely mentioned. Will do a bugs.debian.org report later: https://bugs.debian.org/cgi-bin/pkgreport.cgi?dist=unstable;package=whiptail

MichaIng commented 4 years ago

Bug reported: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=945320