Closed MichaIng closed 3 years ago
Hi,
probably found an issue on frp
. During install I'm ask to select Server
, Client
or Both
. And now I try to cancel
the dialog, which is not working. I'm locked into a loop as I need to do a selection
[ERROR] A choice is required to finish the frp install.
Jep, that is expected as a choice is required to know which service to install and setup, which is also the reason this install option has the aSOFTWARE_INTERACTIVE flag. Or shall we allow to cancel and then do a default choice? Which default would be best?
A dietpi.txt
option would be actually nice as well. But sooner or later we need to split those out into a dedicated software config file, to not overload dietpi.txt
too much 😄.
If I cancel at this stage, I would expect to cancel the installation. What would be the meaning of a cancellation button, if I can't use it? 😉
whiptail actually has the --nocancel
option to hide the cancel button, I just never implemented it into G_WHIP functions, as the cases are very rare. But indeed it makes sense here.
An option to really cancel the install doesn't make sense, does it? I mean who starts to install a software title to then abort it when being asked for a setup choice?
True, might be an extremely rar case.
DietPi v7.3 has been released: https://dietpi.com/docs/releases/#june-2021-version-73
Many thanks to all testers 👍.
How to apply: https://github.com/MichaIng/DietPi/blob/master/BRANCH_SYSTEM.md
Related/solved issues: https://github.com/MichaIng/DietPi/issues?q=is%3Aissue+milestone%3Av7.3
Beta v7.3.2
(2021-06-26)
Changes
New Software
Removed Software
Fixes
@shao
for reporting this issue: https://dietpi.com/phpbb/viewtopic.php?p=35072#p35072