DietPi-LetsEncrypt | certbot fails for any webservice other than `/var/www/`

[nuke-web3]

Creating a bug report/issue

Required Information

• DietPi version | :point_down:
• Distro version | bullseye 0
• Kernel version | Linux 5.15.56-v8+
• SBC model | RPi 4 Model B (aarch64)

G_DIETPI_VERSION_CORE=8
G_DIETPI_VERSION_SUB=8
G_DIETPI_VERSION_RC=1
G_GITBRANCH='master'
G_GITOWNER='MichaIng'

Additional Information (if applicable)

• Software title | LetsEncrypt
• Was the software title installed freshly or updated/migrated? modified server config after install

Steps to reproduce

1. try to use dietpi-letsencrypt manually
2. fails with:

   
   Performing the following challenges:
   http-01 challenge for some.site.com
   Using the webroot path /var/www for all unmatched domains.
   Waiting for verification...
   Challenge failed for domain some.site.com
   http-01 challenge for some.site.com
   Cleaning up challenges
   Some challenges have failed.

IMPORTANT NOTES:

• The following errors were reported by the server:

  Domain: some.site.com Type: unauthorized Detail : Invalid response from https://some.site.com/.well-known/acme-challenge/: 404

  To fix these errors, please make sure that your domain name was entered correctly and the DNS A/AAAA record(s) for that domain contain(s) the right IP address. [FAILED] DietPi-LetsEncrypt | Certbot failed, please check its above terminal output. Aborting...

Expected behaviour

• Cert renewal works manually
• Cert renewal works automatically (ideally 30 days before expiry)
• dietpi either detects or is instructed manually where the document-root of the server is (see details below)

Actual behaviour

• Cert fails, and isn't automatically updated.

Extra details

• I have a custom lighttp (installed via dietpi's interface) that uses the config (/etc/lighttpd/lighttpd.conf) with server.document-root = "/var/www/some-dir/"
• I suspect this is the reason for the failure, as the script tries to update the cert challence in /var/www/
• What does work is certbot renew --webroot -w /var/www/some-dir as expected.

[Joulinar]

Thx for highlighting this. At the moment this works as designed as we hardcode the web root dir inside our script

https://github.com/MichaIng/DietPi/blob/747ad2211c438fe7607aa522dd2e038a7856c646/dietpi/dietpi-letsencrypt#L87

Therefore, I marked your issue as feature request to improve the behavior.