Open murraythegoz opened 11 months ago
Right, this choice was meant as a "do you want to enable it or do you not want to enable it" choice, instead of "or do you want to disable it".
We could change that to have a previously enabled public access block removed when selecting "NO", but then the wording needs to be changed to reflect that. What I am a little concerned about is that non-interactive reinstalls would then always remove the block. So actually it would require a little more rework:
However, the prompt tells you the oneliner commands to enable/disable the block by yourself. A reinstall was never meant for only this job, and would be complete overkill 😉.
Creating a bug report/issue
Required Information
DietPi version |
cat /boot/dietpi/.version
G_DIETPI_VERSION_CORE=8 G_DIETPI_VERSION_SUB=22 G_DIETPI_VERSION_RC=3 G_GITBRANCH='master' G_GITOWNER='MichaIng'Distro version |
echo $G_DISTRO_NAME $G_RASPBIAN
bookwormKernel version |
uname -a
Linux orangepi0-306.priv.bth 6.1.53-current-sunxi #3 SMP Wed Sep 13 07:43:05 UTC 2023 armv7l GNU/Linux
SBC model |
echo $G_HW_MODEL_NAME
or (EG: RPi3) OrangePi Zero (1st gen)Power supply used | (EG: 5V 1A RAVpower) Poe Splitter
SD card used | (EG: SanDisk ultra) SanDisk Extreme
Additional Information (if applicable)
echo $G_HW_UUID
Steps to reproduce
ls -l /etc/lighttpd/conf-enabled | grep block lrwxrwxrwx 1 root root 58 Nov 27 2020 99-dietpi-pihole-block_public_admin.conf -> ../conf-available/99-dietpi-pihole-block_public_admin.conf
Expected behaviour
the above symlink should be deleted
Actual behaviour
the above symlink is not deleted
Extra details