search

MichaIng / DietPi

Lightweight justice for your single-board computer!
https://dietpi.com/
GNU General Public License v2.0
4.9k stars 499 forks source link

Removing deprecated parameters from smb.conf #7282

Closed chelobarik closed 19 hours ago

chelobarik commented 3 days ago

The dietpi-software script generates a samba configuration file smb.conf with outdated parameters. The testparm verification script displays the following warnings:

# testparm
Load smb config files from /etc/samba/smb.conf
lpcfg_do_global_parameter: WARNING: The "syslog only" option is deprecated
lpcfg_do_global_parameter: WARNING: The "syslog" option is deprecated
lpcfg_do_global_parameter: WARNING: The "encrypt passwords" option is deprecated

This fix removes deprecated parameters and replaces them with current ones.

MichaIng commented 2 days ago

Thanks, makes sense. But this disables file logging, when not appending file as well. I would actually vote for that, but then we should further increase the syslog log level. "2" implies authentication failures, AFAIK, so that probably makes sense, too.