search

MichaReiser / llvm-node

LLVM 9.0+ Node Bindings
MIT License
183 stars 29 forks source link

Fix build on LLVM 10.0.0 #102

Closed OMantere closed 3 years ago

OMantere commented 4 years ago

Fixed some breaking changes to the 10.0.0 api.

Probably cannot be merged without breaking earlier versions but you might want to use this for LLVM 10 compatibility.

mbrowne commented 4 years ago

As someone who wanted to install this module, thank you for this PR. If anyone else would like to use it while waiting for this PR to be merged, I tagged it on github and you can install it like this:

npm i github:mbrowne/llvm-node#llvm-node-v2.1.1-gitpkg
MichaReiser commented 3 years ago

Thanks for the PR and sorry for the late code review. I'm unfortunately not able to make changes to your PR.

This looks good to me if we gate the change to LLVM 10+ only to maintain backward compatibility.

OMantere commented 3 years ago

@MichaReiser Added LLVM version branch.

MichaReiser commented 3 years ago

Thx