Define NOMINMAX to fix compilation on Windows

MichaReiser / llvm-node

LLVM 9.0+ Node Bindings

MIT License

183 stars 29 forks source link

Define NOMINMAX to fix compilation on Windows #89

Closed emlai closed 5 years ago

emlai commented 5 years ago

Without this the max macro defined on Windows will cause errors in LLVM headers:

c:\users\emlai\src\libs\llvm-8.0.0-windows-amd64-msvc15-libcmt-dbg\include\llvm\adt\stlextras.h(1438): warning C4003: not enough arguments for function-like macro invocation 'max' [C:\Users\emlai\src\ts-llvm\node_modules\llvm-node\build\llvm-node.vcxproj]

MichaReiser commented 5 years ago

Thank you for your contribution. I assume your patch ensures that llvm-node works fine on windows?