search

Michael-Beutling / equateplus-moneymoney

MoneyMoney Plugin for equateplus share depot
MIT License
8 stars 4 forks source link

Login OK, amount empty #9

Open TurboAsterix opened 3 years ago

TurboAsterix commented 3 years ago

Hello,

the EquatePlus extension v1.16 successfully logs into the Equate Plus Depot, successfully returns an account, but both Equate Plus and Equate Plus (cumulative) return only 0,00 € values.

Best regards, TurboAsterix

Michael-Beutling commented 3 years ago

Hello,

the main problem is that every plan have that own data format, but I can only debug with my plan. See also the other issues. At the moment I have no really an idea how to handle that.

best regards Micha

TurboAsterix commented 3 years ago

Yes, funnily the mapping seems just to be a little different.

SELL_PURCHASE_PRICE: table unit: table precision: number amount: number $type: string'Value' UNDERLYING_VEHICLE: string'xxx' BOOKING_ENTITY: string'xxx' TRANSACTION_ID: string'xxx' VEHICLE: string'xxx' QUANTITY: table status: string'xxx' precision: number amount: number $type: string'xxx' INSTITUTION_NAME: string'xxx' VIEW_IDENTIFIER: string'xxx' VESTED_POSITIONS_VIEW: string'xxx' ASSET_TYPE_IN_OMNIBUS: string'xxx' ID: string'xxx' ACTIVITY_TYPE: string'xxx' ACTIVITY: string'xxx' TRANSACTION_DATE: table date: string'xxx' presentation: string'xxx' $type: string'xxx'

TurboAsterix commented 3 years ago

Hello,

I created a corresponding fork to reflect the changed mapping I desire: https://github.com/TurboAsterix/equateplus-moneymoney

I hopefully have given all credits to you in a correct way; if not please let me know and I will certainly adjust it.

In general we could work to make the mapping more configurable; however from "outside" I think there is no known way to determine which mapping set would be the correct one.

We could merge everything back into your repository like with if(v["COST_BASIS"] OR v["SELL_PURCHASE_PRICE"] OR <whatever>)then but I am not sure if this is a good idea, too, as you can never really test it in a reliable manner.

Instead of hard-coding the conditions another option be to allow a certain list of values from a .ini file etc. for each line item. We would need to abstract them and assume and hope that at least the EquatePlus structures are always similar and only the names are different.

Best regards, TurboAsterix

tbrandt77 commented 3 years ago

Hi @TurboAsterix,

I assume we both join the same SE. Have you found a way to sign your LUA file?

Best regards, Thilo

TurboAsterix commented 3 years ago

Hi @tbrandt77

I wrote today to MRH applications (MoneyMoney vendor) and asked about the signature; I update here once I get a reply.

Best regards, TurboAsterix

TurboAsterix commented 3 years ago

Hi @tbrandt77

a signed version is now available here: https://github.com/TurboAsterix/equateplus-moneymoney/releases/tag/v1.16

Have fun :-)

Best regards, TurboAsterix

tbrandt77 commented 3 years ago

Hi @TurboAsterix,

ok, works for me. Thanks for that!

Two issues I see so far: 1) Do get only OWN by no GROW vehicle. 2) Cumulative number of positions in OWN vehicle does not consider sold stocks. ==> total qty is wrong

Best regards, Thilo

LED321 commented 3 years ago

Hi @TurboAsterix

sorry for the newbie question, but how did you get the mapping file?

Thanks.

TurboAsterix commented 3 years ago

@LED321 If you look at the end of my Lua Script, there is a function dump. This function can print nested tables to the MoneyMoney Console. I dumped out the required tables incl. the data and tried to make sense about the existing mapping and the fields returned to me by my EquatePlus account.

Best regards, TurboAsterix

LED321 commented 3 years ago

@TurboAsterix Thanks for the quick reply. I managed to get the debug protocol.

For me, @Michael-Beutling script works but doesn't show the name of the vehicle. It only shows "(Unbekannt)" in MoneyMoney. Nevertheless the debug file shows a value "VEHICLE_DESCRIPTION":"XXXXX YYYYYY",. Could this be caused by the blank between XXXXX and YYYYY?

The cumulative view doesn't work at all and throws the following error. I suspect that this is also linked to the issue above. > ######################### 8< please report this bug = 'EquatePlus.lua:260: attempt to concatenate field 'VEHICLE_DESCRIPTION' (a nil value)' >8 ######################### 1> ######################### 8< please report this bug version=1.16 >8 ######################### But the field 'VEHICLE_DESCRIPTION' is available.

Cheers, LED321

tbrandt77 commented 3 years ago

@andre68723 It only fetches OWN on my installation. The other two types I do not see.