Generalized include_dir to accept multiple args

Michael-F-Bryan / include_dir

The logical evolution of the include_str macro for embedding a directory tree into your binary.

https://michael-f-bryan.github.io/include_dir

MIT License

319 stars 36 forks source link

Generalized include_dir to accept multiple args #94

Open darthdeus opened 1 year ago

darthdeus commented 1 year ago

I'm not sure if this PR should even be merged as is, I'm partially opening it in case someone else runs into this as well.

The issue being when you want to call include_dir from another macro and compose the path, e.g. as

include_dir!("foo/" $bar "/baz");

kolbma commented 9 months ago

@darthdeus Maybe you should rebranch your PR without changing crate names!

But I'd love to get this into include_dir. Not sure why there is this limitation to a fixed single string?!

@Michael-F-Bryan Do you have any comments?

darthdeus commented 9 months ago

Oops sorry I had to rename the crate in order to publish comfy-core. I completely forgot I made this PR, and when I wanted to release comfy-core that has a dependency on this PR I ran into the issue that crates.io won't let you depend on github.

The only apparent solution being "republish as a new crate", which is what I did in order to be able to publish my crate.