search

Michael-F-Bryan / rust-ffi-guide

A guide for doing FFI using Rust
https://michael-f-bryan.github.io/rust-ffi-guide/
Creative Commons Zero v1.0 Universal
282 stars 18 forks source link

Fix & improve "Setting Up" section to match code and fix buildsystem fails #60

Closed kossebau closed 6 years ago

kossebau commented 6 years ago

Thanks for sharing your guide, Qt for UI and Rust for business logic is exactly what I currently want to explore a little.

Here some proposals to fix things I stumpled over in the "Setting up" section.

kossebau commented 6 years ago

Sigh... commit "No need to explicitely call show() on a child widget " slipped accidentally in, was not yet meant for you, sorry, removing now. (been some time I did stuff on github, please pardon my mess)

Michael-F-Bryan commented 6 years ago

I'm pretty happy with these changes. Like I've mentioned before, I was jumping around a bit when writing the guide because I'd find I missed something and would have to go back, so the exact build instructions probably weren't correct.

It looks like having a fresh set of eyes follow through from start to finish helps with picking up these sorts of issues :slightly_smiling_face:

kossebau commented 6 years ago

I was jumping around a bit when writing the guide because I'd find I missed something and would have to go back, so the exact build instructions probably weren't correct.

Understood. Found the text and tutorial flow itself pretty good and correct, good work there from what I can tell. So had a good experience otherwise and left the existing chapters without big questionmarks but new knowledge instead, thanks again for providing the tutorial :)