Move to Timeouts - Githubissues

Michael-J-Scofield / discord-anti-spam

A simple discord anti spam node.js module to prevent spam on your discord server

MIT License

146 stars 53 forks source link

Move to Timeouts #150

Closed TheUntraceable closed 2 years ago

TheUntraceable commented 2 years ago

Please describe the changes this PR makes and why it should be merged:

This pr aims to move all mutes to the new Timeout feature DiscordJS v13.4 has. I haven't tested this but it should work. I wish I could edit the docs but I'm not the best with HTML and will leave that for someone to take a look at. I scrapped the unMute function as Discord now handles that.

Status and versioning classification:

This PR changes the library's interface (methods or parameters added)

Scraayp commented 2 years ago

I will review this code after my break.

TheUntraceable commented 2 years ago

Sounds good, I also went ahead and added support for multiple guilds, I hope you have a good break 👍.

Scraayp commented 2 years ago

You forgot to update readme to add the multiple guild.

Also, I don't think it's smart to add multiple guild option. This package is a easy to build package soo that people can read the code with ease and learn how to code it themself. About if too add it, idk yet.

Scraayp commented 2 years ago

Also the docs are automatic. Just run:

npm install

npm run generate-docs

TheUntraceable commented 2 years ago

I updated the docs and the README, thanks for letting me know about JSDocs, I'll probably implement it into my own projects.

Scraayp commented 2 years ago

Okay,

Could you test everything out on a test bot. To make sure everything works, after I get the confirmation of you. I will push the pr.