search

MichaelAquilina / zsh-auto-notify

⏰ ZSH plugin that automatically sends out a notification when a long running task has completed.
GNU General Public License v3.0
412 stars 42 forks source link

Add option oppsite to AUTO_NOTIFY_IGNORE #20

Closed webhive closed 5 years ago

webhive commented 5 years ago

Issue Details

This plugin is helpful for me, but with my workflow I need it only for certain commands, but not to each one. So current behaviour is pretty annoying. Add commands to AUTO_NOTIFY_IGNORE seems an overhead as I adding more and more there. So it could be great to have some option to use this plugin to subset of allowed commands which are really need my attention instead of flood me with tons of notices.

Operating System (uname -a)

Linux 5.2.6-arch1-1-ARCH #1 SMP PREEMPT Sun Aug 4 14:58:49 UTC 2019 x86_64 GNU/Linux

zsh version (zsh --version)

zsh 5.7.1 (x86_64-pc-linux-gnu)

auto-notify version (echo "$AUTO_NOTIFY_VERSION")

0.4.0

How is auto-notify installed?

MichaelAquilina commented 5 years ago

It's a good suggestion. Right now AUTO_NOTIFY_IGNORE is basically a blacklist. What you are suggesting is basically asking for an explict whitelist instead. Should be pretty easy to implement. Would you like to try giving this a go yourself? Happy to do it myself otherwise

MichaelAquilina commented 5 years ago

@webhive please see if #21 solves your issue

webhive commented 5 years ago

Briefly tested - seems work

MichaelAquilina commented 5 years ago

Merged into master. Hope that helps you with your issue :)