MichaelAquilina / zsh-auto-notify

⏰ ZSH plugin that automatically sends out a notification when a long running task has completed.
GNU General Public License v3.0
412 stars 42 forks source link

Unknown option --transient #46

Closed engeir closed 1 year ago

engeir commented 1 year ago

Issue Details

Some long running commands get a notification as expected, while others (running and finishing nvim typically get this error) do not get a notification, but instead a warning message is printed:

$ nvim
Unknown option --transient

I suppose it is related to these lines.

Operating System (uname -a)

Linux ubuntu-work 5.19.0-41-generic #42~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Tue Apr 18 17:40:00 UTC 2 x86_64 x86_64 x86_64 GNU/Linux

zsh version (zsh --version)

zsh 5.8.1 (x86_64-ubuntu-linux-gnu)

auto-notify version (echo "$AUTO_NOTIFY_VERSION")

0.8.0

How is auto-notify installed?

Installed with zap.

Steps to reproduce the issue

With zap, installation is done as: link to location in zshrc

# .zshrc
...
plug "MichaelAquilina/zsh-auto-notify"
...

gist link to your zshrc

zshrc files are form the zsh_mac directory (also my when on my linux machine): zsh_mac.

MichaelAquilina commented 1 year ago

Definitely related to #41

What does notify-send --version show for you @engeir ?

engeir commented 1 year ago

I'm on

$ notify-send --version
notify-send 0.7.9
engeir commented 1 year ago

I believe the --transient option was added in notify-send version 0.7.11 (NEWS), and that before that transient was specified with --hint=int:transient:1.

I made a fork which works for me locally (fix-transient), which I hope can be useful.

I have not been able to test on a newer version of notify-send, it seems to be the latest available for me on ubuntu/apt (see below), but from the NEWS file it seems like the old --hint=int:transient:1 is still available.

$ sudo apt-get install libnotify-bin
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
libnotify-bin is already the newest version (0.7.9-3ubuntu5.22.04.1).
0 upgraded, 0 newly installed, 0 to remove and 21 not upgraded.
MichaelAquilina commented 1 year ago

@Grafcube as the author of the original PR, could you confirm --hint=int:transient:1 works for you?

I can confirm that it seems to work for me on notify-send 0.8.2

Grafcube commented 1 year ago

@Grafcube as the author of the original PR, could you confirm --hint=int:transient:1 works for you?

I can confirm that it seems to work for me on notify-send 0.8.2

I can confirm that --hint=int:transient:1 works for me on notify-send 0.8.2.

MichaelAquilina commented 1 year ago

Please try out the latest release and let me know if it works for you :)

engeir commented 1 year ago

This works for me :)