search

MichaelAquilina / zsh-auto-notify

⏰ ZSH plugin that automatically sends out a notification when a long running task has completed.
GNU General Public License v3.0
404 stars 41 forks source link

Add configuration options for notification urgency #49

Open niraami opened 10 months ago

niraami commented 10 months ago

Builds upon and replaces #24

Gives the user access to 2 configuration options that affect what urgency is used for the notification.

I've also added a test case for the ON_SUCCESS urgency option. I was unfortunately not able to figure out how to add a test case for the ON_ERROR option without modifying unrelated parts of the code quite heavily. I've also added a section in the README, but I'm unfamiliar with the formatting, and my VS Code extension is not rendering it properly, so I just copied the style nad hope it works :)

niraami commented 8 months ago

Thoughts? I've been using my fork for a while now, seems fine. @MichaelAquilina