search

MichaelAquilina / zsh-auto-notify

⏰ ZSH plugin that automatically sends out a notification when a long running task has completed.
GNU General Public License v3.0
415 stars 42 forks source link

Escape backslash in notification message for macOS #6

Closed mrymtsk closed 5 years ago

mrymtsk commented 5 years ago

This fixes #1. Double quotes must be escaped in AppleScript, therefore they should be \\\" in echo. https://github.com/MichaelAquilina/zsh-auto-notify/blob/23cf128eb19a1d6f1a4ce3ba92b19b161a812bb1/auto-notify.plugin.zsh#L21

MichaelAquilina commented 5 years ago

I have an idea of how to simplify this but happy to merge this for now to get the fix out quickly

mrymtsk commented 5 years ago

Yeah I agree that this is not the best way. Thanks anyway!

Sent with GitHawk

MichaelAquilina commented 5 years ago

Just pushed a change to simplify this in master. Would you mind re-testing on the latest version to make sure it still works?

mrymtsk commented 5 years ago

Works as expected.

Sent with GitHawk

MichaelAquilina commented 5 years ago

Thanks for checking mrymystk! :D