MichaelAquilina / zsh-autoswitch-virtualenv

🐍 ZSH plugin to automatically switch python virtualenvs (including pipenv and poetry) as you move between directories
GNU General Public License v3.0
507 stars 80 forks source link

check python if AUTOSWITCH_DEFAULT_PYTHON is set #183

Closed adamko147 closed 1 year ago

adamko147 commented 1 year ago

Fixes #182

MichaelAquilina commented 1 year ago

I think the CircleCI failure is unrelated and possibly due to an incident within circleci itself. I'll trigger a rebuild at a later stage.

adamko147 commented 1 year ago

I think the CircleCI failure is unrelated and possibly due to an incident within circleci itself. I'll trigger a rebuild at a later stage.

Thanks, when I try to trigger CircleCI on my repo, I got an error https://app.circleci.com/pipelines/github/adamko147/zsh-autoswitch-virtualenv/1/workflows/6789aad5-6563-40ee-bc20-1138d960d7e9/jobs/2?invite=true#step-105-203 saying

✘ correct version exported
'3.6.0' is not the same as ''

which I think is also not related to the change I did.

cunha commented 1 year ago

I just ran into this issue; and it's nice that we have a solution. Just bumping to +1 the merge.

MichaelAquilina commented 1 year ago

@adamko147 could you try rebasing your PR on latest main to see if the circleci issue is resolved? I tried re-opening the PR to see if it would trigger again but that did not work

adamko147 commented 1 year ago

@adamko147 could you try rebasing your PR on latest main to see if the circleci issue is resolved? I tried re-opening the PR to see if it would trigger again but that did not work

@MichaelAquilina hm, can't do that, GH says my branch is up to date with your master. I've opened new PR https://github.com/MichaelAquilina/zsh-autoswitch-virtualenv/pull/188 instead but that did not trigger the CI either...

adamko147 commented 1 year ago

@MichaelAquilina any idea how to re-trigger the CircleCI on the PR? Thanks!

fnicastri commented 1 year ago

@MichaelAquilina Will you merge this?

MichaelAquilina commented 1 year ago

Thank you for the change and sorry for the delay :)