search

MichaelAquilina / zsh-you-should-use

📎 ZSH plugin that reminds you to use existing aliases for commands you just typed
GNU General Public License v3.0
1.46k stars 43 forks source link

gpsup doesn't trigger you-should-use #15

Closed seanlerner closed 6 years ago

seanlerner commented 7 years ago

I have the following alias setup:

gpsup='git push --set-upstream origin $(git_current_branch)'

I've enabled hardcore mode, but you-should-use doesn't get in the way of this command:

gp --set-upstream origin my-branch-name
MichaelAquilina commented 7 years ago

the problem is that the plugin does not evaluate variables within aliases. It could probably be exploitable if not handled correctly so I will consider if its something worth doing or not.

MichaelAquilina commented 6 years ago

Closing this issue because its non-trivial and very likely exploitable from a security perspective if implemented in some way.