Release 0.2.0 - Githubissues

MichaelAquilina / zsh-you-should-use

📎 ZSH plugin that reminds you to use existing aliases for commands you just typed

GNU General Public License v3.0

1.46k stars 43 forks source link

Release 0.2.0 #22

Closed MichaelAquilina closed 7 years ago

MichaelAquilina commented 7 years ago

Adds testing for multiple versions of ZSH
Fixes bugs around BESTMATCH and ordering of results
Handle multiple options for BESTMATCH by choosing alias with shortest length
Change default mode to BESTMATCH

MichaelAquilina commented 7 years ago

Try use is_substring_of assert function if zunit 0.8.0 releases before next release

MichaelAquilina commented 7 years ago

@molovo not sure if you're interested, but I am looking for someone to review my code before I merge it. Usually I get different people to do it and since I interacted with you last thought it would be worth a try. Feel free not to if you dont feel like though :)

molovo commented 7 years ago

@MichaelAquilina sure, I'll take a look

MichaelAquilina commented 7 years ago

Thanks for the review @molovo, let me know if I can help out with anything!

molovo commented 7 years ago

@MichaelAquilina just trying this out locally, and noticed that occasionally you-should-use will report twice for different aliases when a shorter one exists.

screen shot 2017-07-05 at 12 07 53

Is this expected? It's present in the current master as well

molovo commented 7 years ago

In fact, managed to get it to report three times here:

screen shot 2017-07-05 at 12 13 29

Want me to raise an issue?

MichaelAquilina commented 7 years ago

by default the package shows all matched results. Have you set export YSU_MODE=BEST?

molovo commented 7 years ago

@MichaelAquilina Ah! Knew I was missing something. Thanks

MichaelAquilina commented 7 years ago

No problem! It tells me that I should probably make this option more visible or possible rethink the default since you are not the first one to have this problem