MichaelAquilina / zsh-you-should-use

📎 ZSH plugin that reminds you to use existing aliases for commands you just typed
GNU General Public License v3.0
1.49k stars 44 forks source link

Make hardcore mode more distinguished #50

Closed selfish closed 6 years ago

selfish commented 6 years ago

This changes non-hardcore to mention you "can" use, to imply that it's optional, while hardcore mode will mention you should. This comes from complaints I have heard around, where people mentioned YSU is harsh even not using hardcore.

If you don't like that change feel free to dismiss the PR of course. This is intended as a suggestion. :)

MichaelAquilina commented 6 years ago

Hi @selfish thanks for the PR / suggestion.

As the change stands, it does not work as you have described - but I am not convinced that the change should be merged either way.

Maybe you could describe some of the frustrations you have heard so that we can think of other ways ti solve them together?

selfish commented 6 years ago

Sure thing. The point my colleagues bring up is that the wording "you SHOULD use" sounds too strict for someone who just want the info, but not to be forced to use the alias.

I can relate to what they are saying. I personally use hardcore mode, so for me should an even must are okay. For them, they want plain info, so the reminder should be more friendly. That's what they say.

WDYT?

MichaelAquilina commented 6 years ago

Sounds like they can just customize their message to be whatever they want it to be :)

https://github.com/MichaelAquilina/zsh-you-should-use#customising-messages

Maybe something like:

export YSU_MESSAGE_FORMAT="\e[31mFound an alias for %command: %alias\e[0m"

selfish commented 6 years ago

Great resolution, thanks!