search

MichaelAquilina / zsh-you-should-use

📎 ZSH plugin that reminds you to use existing aliases for commands you just typed
GNU General Public License v3.0
1.42k stars 44 forks source link

Replaced $ZSH to $ZSH_CUSTOM in Readme #62

Closed idoo closed 5 years ago

MichaelAquilina commented 5 years ago

Hi @idoo could you provide some context on what this change is meant to do?

What is $ZSH_CUSTOM and why is it better to use than $ZSH?

idoo commented 5 years ago

@MichaelAquilina because in the OMZSH docs there is an example on customization section contains $ZSH_CUSTOM instead of $ZSH + custom.

Initially $ZSH_CUSTOM points to oh-my-zsh's custom directory.

and

To override a plugin with a custom version, put your custom version at $ZSH_CUSTOM/plugins//.

I guess that path should use more constant as possible :)

Please feel free to close it if you prefer another way :)

MichaelAquilina commented 5 years ago

After reading the link you provided I am happy with including this change. But could you please update the PR the link you provided in the README? :)

idoo commented 5 years ago

@MichaelAquilina done

MichaelAquilina commented 5 years ago

Thanks for the PR @idoo !