search

MichaelBelgium / mybb_to_flarum

A Flarum extension to convert a mybb forum to a fresh flarum install
MIT License
26 stars 15 forks source link

Slight improvements #1

Closed dshovchko closed 7 years ago

dshovchko commented 7 years ago
  1. correct work with Cyrillic
  2. increase max execution time for script
MichaelBelgium commented 7 years ago

Useful improvements but while using the time limit, isnt it better to set it 0?

dshovchko commented 7 years ago

Really, somehow did not think about it. I have corrected

MichaelBelgium commented 7 years ago

@dshovchko Maybe changing to UTF8 wasn't a good idea, truncating tables are not working anymore. Unless u can fix it, feel free to commit again. (Or isn't it due the charset? It worked before ..)

Cannot truncate a table referenced in a foreign key constraint (flar_recipients, CONSTRAINTrecipients_discussion_id_foreignFOREIGN KEY (discussion_id) REFERENCES .flar_discussions(id))

For now i found $flarum_db->query("SET FOREIGN_KEY_CHECKS=0;");

Also some slugs are empty.

dshovchko commented 7 years ago

It's strange. It works for me perfectly.

I think, it's not because of UTF8. Try to clear the base and perform migration again.

PS. Perhaps, you didn't truncate all necessary tables.

dshovchko commented 7 years ago

In my DB isn't such table "recipients"!

MichaelBelgium commented 7 years ago

Ah! Yeah indeed, I wanted to test and installed this private discussions extension, that created this table. In case i could migrate private messages into these private discussions. Discarded all my edits, restarted from this git and works now (: