search

MichaelCereda / react-native-form-generator

Generate forms with native look and feel in a breeze
MIT License
377 stars 105 forks source link

Android doesn't show the input when a label is provided #102

Closed johncblandii closed 7 years ago

johncblandii commented 7 years ago

You can see what happens when I hot reload the app with a containerStyle and without it.

Shows the text input but it isn't full width: <InputField ref='subject' label='Subject' containerStyle={{alignItems: 'flex-start'}} />

Doesn't show the text input at all: <InputField ref='subject' label='Subject' />

Using a placeholder does properly display the input, but only if there is no label provided. This is using the latest master version.

gif

johncblandii commented 7 years ago

Any thoughts, @MichaelCereda?

Also, ignore the stack trace in there. I hit save too quick at one point.

jbrodriguez commented 7 years ago

@johncblandii I was having the same issue.

Turns out npmjs doesn't have the latest code from master.

It's 6 months old and that threw me off for a while, had to go back to basics :)

I installed the latest commit from github and all the problems went away.

MikeDabrowski commented 7 years ago

Sorry, I'm bit new to this things. How to install it from github? Just copy paste files over those from npmj?

johncblandii commented 7 years ago

Hrmmm....I thought I had master in there, but guess not. We really do need to get proper releases going on this repo so we can read the release notes, etc.

The forms look like crap on Android vs iOS. I'll test this more later to see how this works out.

jbrodriguez commented 7 years ago

@johncblandii I hear you 👍

@MikeDabrowski you can do

yarn add MichaelCereda/react-native-form-generator#1bebb69
MikeDabrowski commented 7 years ago

@johncblandii Yeah they do look like crap on android. I like the default look so at first I went vanilla but gathering the data from it later is bit painful. If one could merge the two ... that'd be nice :D

@jbrodriguez Can I do it with npm? I don't have yarn on windows installed.

jbrodriguez commented 7 years ago

@MikeDabrowski it would be

npm install MichaelCereda/react-native-form-generator.git#1bebb69
MikeDabrowski commented 7 years ago

Great thanks

johncblandii commented 7 years ago

Master does work so I'm going to consider this closed, but a proper release needs to be pushed.

qrobin commented 7 years ago

Same problem here. npm install MichaelCereda/react-native-form-generator.git#1bebb69 didn't help.