MichaelCereda / react-native-form-generator

Generate forms with native look and feel in a breeze
MIT License
377 stars 105 forks source link

Adding new Component CountDownField #111

Closed EnricoGallus closed 6 years ago

EnricoGallus commented 7 years ago

Hey Michael,

I really like the generator, though, i haven't used so much features so far. I need a component in the form which represents the CountDown-mode of the DatePickerOS, i just added the mode to the react-native project as well (DatePickerIOS will give a warning until my changes are not in the master but of course accept the value). I was not sure if i should overwrite the CountDownField.android.js as well. I copied the TimePickerField and changed the provided mode and tried to keep the structure and flow i have spotted from the source code. Maybe we have to style this component a bit different, that's why i copied it instead of providing a mode-prop to the TimePickerField and setting a default value. Please have a close look, i'm new to React-Native programming and of course appreciate any hint about improvements.

Greetings, Enrico