MichaelCereda / react-native-form-generator

Generate forms with native look and feel in a breeze
MIT License
377 stars 105 forks source link

Difference between iOS and Android #51

Open pcrouillere opened 8 years ago

pcrouillere commented 8 years ago

In iOS everything work but on Android the "right Icon" is not on the same line.. Do you know why ?

Here's my code : <InputField ref='login' placeholder={I18n.t('mail')} returnKeyType={"next"} keyboardType={"email-address"} validationFucntion={this.props.validateLogin} iconRight={ <Icon name='ios-arrow-forward' size={30} style={[ {alignSelf:'center',marginRight:10, color: "#61d062"}, ((self) => { if (!!(self.refs.loginForm && self.refs.loginForm.refs.login)) { if (!self.refs.loginForm.refs.login.valid) return {color: '#d52222'} } })(this)]} /> } onEndEditing={() => { this.props.validateLogin(); this.refs.loginForm.refs.pwd.focus() }} />

pcrouillere commented 8 years ago

@MichaelCereda
Apparently we can make it work :)

You just have to add a few change in "InputField.android.js" : see here : https://gist.github.com/pcrouillere/9cded78d2e32864df425e8874b802f61

MichaelCereda commented 8 years ago

oh. great.. would you mind to submit a pr? I'm afk now, but I'll check the code later. Thank you for using my project

On Fri, Aug 19, 2016 at 10:07 AM pcrouillere notifications@github.com wrote:

@MichaelCereda https://github.com/MichaelCereda

Apparently we can make it work :)

You just have to add a few change in "InputField.android.js" : see here : https://gist.github.com/pcrouillere/9cded78d2e32864df425e8874b802f61

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/MichaelCereda/react-native-form-generator/issues/51#issuecomment-241027941, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGjfr64LXoRtCDPW62BqYV7ezWzp6KIks5qhbiPgaJpZM4JofBz .

Michael Cereda http://michaelcereda.com

MichaelCereda commented 8 years ago

Yes.. I bet that this is the goal of everyone ;) Can I see a screenshot, i think that it's actually very easy to solve.

Which react native version are you using?

giannas commented 8 years ago

I was in the wrong repo, I clearly need a break!

MichaelCereda commented 8 years ago

lol, go get a coffee :)