search

MichaelChirico / potools

Tools for working with translations in R
https://michaelchirico.github.io/potools/
58 stars 2 forks source link

fix .po/.pot reading issue #167

Closed MichaelChirico closed 3 years ago

MichaelChirico commented 3 years ago

Closes #98

The issue was that we assumed msgid " when it's actually msgid +" is valid.

However I'm not sure how to test this (notably, the issue was already affecting the .pot file in r_fuzzy)...

codecov-commenter commented 3 years ago

Codecov Report

Merging #167 (419b3ed) into master (159be95) will increase coverage by 0.00%. The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #167   +/-   ##
=======================================
  Coverage   97.62%   97.63%           
=======================================
  Files          15       15           
  Lines        1181     1182    +1     
=======================================
+ Hits         1153     1154    +1     
  Misses         28       28
Impacted Files Coverage Δ
R/get_po_messages.R 91.35% <85.71%> (+0.10%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 159be95...419b3ed. Read the comment docs.

MichaelChirico commented 3 years ago

Will try and deal with coverage later...