search

MichaelChirico / potools

Tools for working with translations in R
https://michaelchirico.github.io/potools/
58 stars 2 forks source link

Faster implementation of get_src_messages #189

Closed MichaelChirico closed 3 years ago

MichaelChirico commented 3 years ago

get_message_data("~/svn/R-devel/src/library/base") reduced from circa 14 seconds to circa 7.

Not a life-changing improvement, but noticeable nonetheless.

Tested it works on all of base.

Closes #119 for now

codecov-commenter commented 3 years ago

Codecov Report

Merging #189 (b8c79ad) into master (fbc7648) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   98.97%   98.97%   -0.01%     
==========================================
  Files          17       17              
  Lines        1268     1263       -5     
==========================================
- Hits         1255     1250       -5     
  Misses         13       13
Impacted Files Coverage Δ
R/get_src_messages.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fbc7648...b8c79ad. Read the comment docs.

MichaelChirico commented 3 years ago

lines -n, hits -n issue rears its head again :roll_eyes: