MichaelChirico / potools

Tools for working with translations in R

https://michaelchirico.github.io/potools/

58 stars 3 forks source link

WIP: vignette for package developers #237

Closed hadley closed 2 years ago

MichaelChirico commented 2 years ago

Let me know if you want any eyes on this while it's still in WIP/Draft mode

codecov-commenter commented 2 years ago

Codecov Report

Merging #237 (4a8c5d6) into master (583db64) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files          17       17           
  Lines        1351     1351           
=======================================
  Hits         1335     1335           
  Misses         16       16

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 583db64...4a8c5d6. Read the comment docs.

hadley commented 2 years ago

Fixes #233. Fixes #228. Fixes #231.

hadley commented 2 years ago

While this is getting close, I think it probably needs a couple more passes from me before it's worth you spending your time looking at it.

hadley commented 2 years ago

I think this is probably ready for review now. I'd suggest focussing on the bigger picture, and not worrying too much about typos etc yet.

hadley commented 2 years ago

@MichaelChirico ok to merge this? It's not perfect, but we can keep improving it.

MichaelChirico commented 2 years ago

hey! sorry for the delay. I kept stubbornly trying to get snapshot tests working as it continues to feel just out of reach but lost momentum. now trying to find time to pick the other pendings back up.

On Wed, Nov 24, 2021, 9:48 AM Hadley Wickham @.***> wrote:

@MichaelChirico https://github.com/MichaelChirico ok to merge this? It's not perfect, but we can keep improving it.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MichaelChirico/potools/pull/237#issuecomment-978098309, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2BA5IO437M4XG2544J3FTUNUQPTANCNFSM5HJ5HQKQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

hadley commented 2 years ago

I can also try to take a stab at them once I'm done with the pkgdown release (hopefully next week)