search

MichaelChirico / potools

Tools for working with translations in R
https://michaelchirico.github.io/potools/
58 stars 2 forks source link

Upgrade suite to use testthat 3.0 #249

Closed MichaelChirico closed 3 years ago

MichaelChirico commented 3 years ago

Would probably also benefit a lot from using snapshot tests to handle all the output-related stuff

hadley commented 3 years ago

What do you think about also defaulting to verbose = !is_testing()? That's a pattern we've started to use, and it seems to make life a little less complicated.

is_testing <- function() {
    identical(Sys.getenv("TESTTHAT"), "true")
}

Otherwise, it doesn't look like any changes are needed for 3e.

MichaelChirico commented 3 years ago

SGTM! Thanks. I'll also take a pass at moving expect_equal() --> expect_identical()