MichaelChirico / potools

Tools for working with translations in R

https://michaelchirico.github.io/potools/

58 stars 3 forks source link

Update check action #251

Closed hadley closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #251 (e83ead2) into master (4a6f547) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files          17       17           
  Lines        1348     1348           
=======================================
  Hits         1332     1332           
  Misses         16       16

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a6f547...e83ead2. Read the comment docs.

hadley commented 2 years ago

@MichaelChirico do you like the comment giving the code coverage report? (as opposed to the report included with the R CMD check results)? If you don't like it, I can also suppress it in this PR.

MichaelChirico commented 2 years ago

do you like the comment giving the code coverage report? (as opposed to the report included with the R CMD check results)?

sorry I'm just waking up and don't quite follow... this is about the comment codecov not posts to the PR with the results? I don't think I understand the alternative

hadley commented 2 years ago

In this thread you can see the codecov result twice: once as a comment (https://github.com/MichaelChirico/potools/pull/251#issuecomment-962609760) and once under "show all checks". Do you want to see it only under "show all checks"?

MichaelChirico commented 2 years ago

gotcha... I'll have to adjust my workflow but let's give it a try

MichaelChirico commented 2 years ago

thanks!!!