MichaelChirico
commented
4 years ago From: Peter Dalgaard BSA <p.dalgaard@<::CENSORED -- SEE ORIGINAL ON BUGZILLA::>> albrecht.gebhardt@<::CENSORED -- SEE ORIGINAL ON BUGZILLA::>-klu.ac.at writes:
I'm not sure if I understood what was intended by "!arg" (see below),
but with this patch I at least was able to compile. (and R runs now,
but I guess only because I didn't came across this code section)
--- ./src/main/printutils.c.va_list.patch Mon Feb 7 15:08:14 2000
+++ ./src/main/printutils.c Mon Feb 7 15:52:54 2000
@@ -421,7 +421,7 @@
else {
char buf[BUFSIZE], *p = buf, *vmax = vmaxget();
int slen, res;
- if(!arg) {
+ if(&arg!=NULL) {
/* just a string, so length is known */
if((slen = strlen(format)) >= BUFSIZE)
p = R_alloc(slen+1, sizeof(char));Not going to work, "if (0)" will (i.e. always take else branch).
And please check for similar reports before filing a new one, we discussed this at some length earlier today!
--
O_ ---- Peter Dalgaard Blegdamsvej 3
c/ /' --- Dept. of Biostatistics 2200 Cph. N
<CENSORING FROM DETECTED PHONE NUMBER ONWARDS; SEE BUGZILLA>
METADATA
- Comment author - Jitterbug compatibility account
- Timestamp - 2000-02-08 16:34:28 UTC
From: albrecht.gebhardt@<::CENSORED -- SEE ORIGINAL ON BUGZILLA::>-klu.ac.at Full_Name: Albrecht Gebhardt Version: 0.99.0 OS: alpha, osf4.0 Submission from: (NULL) (143.205.180.40)
Both DEC cc and gcc complain (osf4.0, alpha) about applying an unary operator (!) to a non scalar type (va_list arg) in printutils.c
I'm not sure if I understood what was intended by "!arg" (see below), but with this patch I at least was able to compile. (and R runs now, but I guess only because I didn't came across this code section)
--- ./src/main/printutils.c.va_list.patch Mon Feb 7 15:08:14 2000 +++ ./src/main/printutils.c Mon Feb 7 15:52:54 2000 @@ -421,7 +421,7 @@ else { char buf[BUFSIZE], p = buf, vmax = vmaxget(); int slen, res;
METADATA