search

MichaelChirico / r-ci-samples

Sample CI&metadata files from popular R package repos
40 stars 4 forks source link

Better approach for Makefile #5

Open MichaelChirico opened 4 years ago

MichaelChirico commented 4 years ago

e.g. facebook/prophet has ./Makefile and ./docs/Makefile; it appears to be random which will be included --> bigger diff from auto-update.

Not sure a robust way to fix this ATM

JanCaha commented 4 years ago

It could be done in the same way as github actions. Create a folder for each repo and store the makefiles there. The path to file can be turned to a long file name. So your examples would be Makefile and docs_Makefile stored in prophet folder.

I believe that this makes sense for files where more than file can be expected (e.g. Makefile).

MichaelChirico commented 4 years ago

yes that's basically what i was thinking. still feels a bit inelegant... and i would lean towards leaving the full path within the prophet folder:

./prophet
  Makefile
  doc/
    Makefile