Roeya commented 1 month ago

thank you for this great module, I would like the help you improve it a bit

In the source you have a remarked place holder for the author of the file at line 134:

$workbook->{Author} = ...;

please add the code to read the author etc from the XLSX file:

 my $core = $self->_parse_xml($zip, "docProps/core.xml");
 my ($creator) = $core->find_nodes('//dc:creator'); 
 $workbook->{Author}  = $creator->first_child()->dcdata;

This is a bit naive code, but I do not know XML::Twig well enough...

MichaelDaum commented 1 month ago

Would you like to create a pull request? Thanks in advance.

Roeya commented 1 month ago

I will try, not very familiar with github.... )-: last time it took me a day to get it right so if it takes me time please understand.

Regards Roey

On Tue, 9 Jul 2024 at 10:20, Michael Daum @.***> wrote:

Would you like to create a pull request? Thanks in advance.

— Reply to this email directly, view it on GitHub https://github.com/MichaelDaum/spreadsheet-parsexlsx/issues/17#issuecomment-2216794799, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIIPFGTPP33N5T24GK2GXLZLOFLRAVCNFSM6AAAAABKSFKRE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJWG44TINZZHE . You are receiving this because you authored the thread.Message ID: @.***>

--

Roey Almog Infoneto Ltd.

MichaelDaum / spreadsheet-parsexlsx

Reading file information such as author #17

$workbook->{Author} = ...;