MichaelDemidov / DelphiZXingQRCodeEx

Delphi/Lazarus port of QR Code functionality from ZXing, a barcode image processing library. The support for non-standard encodings has been added
Apache License 2.0
65 stars 21 forks source link

Firemonkey support? #2

Open jkaster opened 8 years ago

jkaster commented 8 years ago

I have a refactored version of the original source code that also works for FireMonkey, (just define FMX and it will build for FMX). It looks like the original project has gone idle. Are you also interested in FMX, or should I just make my own fork?

MichaelDemidov commented 8 years ago

Hi, John!

Thank you for your offer. Of course, I'm interested in the further development of this project.

jkaster commented 8 years ago

OK. I'll start working on merging my changes into your code via my own fork

MichaelDemidov commented 8 years ago

OK, but...

Some time ago, I modified the code. Mainly I wanted to add support for new (for Delphi) zero-based strings, but I also wanted to keep compatibility with old Delphi versions—therefore I used all these IFDEFs. I made all the changes locally and now decided to add a new unstable branch test. Unfortunately, I have not had time to test these changes.

Maybe you better use this branch?

jkaster commented 8 years ago

I'll look into it

On Feb 24, 2016, at 7:38 AM, Michael Demidov notifications@github.com wrote:

OK, but...

Some time ago, I modified the code. Mainly I wanted to add support for new (for Delphi) zero-based strings, but I also wanted to keep compatibility with old Delphi versions—therefore I used all these IFDEFs. I made all the changes locally and now decided to add a new unstable branch test. Unfortunately, I have not had time to test these changes.

Maybe you better use this branch?

— Reply to this email directly or view it on GitHub.

jkaster commented 8 years ago

I took care of that differently in my code. Perhaps I should just get mine posted somewhere.

On 2/24/2016 7:38 AM, Michael Demidov wrote:

OK, but...

Some time ago, I modified the code. Mainly I wanted to add support for new (for Delphi) zero-based strings, but I also wanted to keep compatibility with old Delphi versions—therefore I used all these IFDEFs. I made all the changes locally and now decided to add a new unstable branch test. Unfortunately, I have not had time to test these changes.

Maybe you better use this branch?

— Reply to this email directly or view it on GitHub https://github.com/MichaelDemidov/DelphiZXingQRCodeEx/issues/2#issuecomment-188309056.

MichaelDemidov commented 8 years ago

I do not sure that my decision is the best possible. If you have any ideas how to improve it, that would be great. It is the main advantage of any open source project