MichaelDurfey / React-Infinite-Scroll

Exercise in React/Webpack/Babel implementing infinite scrolling using API calls
0 stars 0 forks source link

Infinite Scroll behavior #1

Open daversm opened 6 years ago

daversm commented 6 years ago

Hey Michael, thanks for submitting to our Walmart coding challenge.

Part of the requirement was to implement a infinite-scrolling behavior, I was not able to find the logic in your code for this. Could you link me to the logic for infinite-scroll in your code ?

I do see that the library you used react-virtualized has a InfiniteLoader component available, but it seems that was not used in your code.

MichaelDurfey commented 6 years ago

Hey Daver,

Great catch. I completely overlooked that part of the prompt. I implemented the infinite-scrolling behavior and you should find the main logic for this in src/components/List.jsx and also src/index.jsx for loading of additional rows of content.

Thanks!

MichaelDurfey commented 6 years ago

@daversm were you able to review my edits? Would love to hear any feedback you might have. Thanks!