MichaelFenwick / Color

A simple Dart package exposing a Color class which can be used to create, convert, and compare colors.

http://pub.dartlang.org/packages/color

MIT License

52 stars 18 forks source link

fix type problems when compiling with DDC #13

Closed robbecker-wf closed 7 years ago

robbecker-wf commented 7 years ago

Overview

There are type errors when trying to compile with the Dart Development Compiler (DDC).

Solution

Fix the dynamic-ish filter functions to convert to the correct types that are expected. They will have already been converted with the _convert function, but this makes the compiler happy.

Testing

Use Dart >= 1.24.0 with DDC
pub serve --web-compiler=dartdevc demo
load localhost:8080 with regular Chrome, not Dartium. It should load the demo page.

evanweible-wf commented 7 years ago

+10

[x] Demo page correctly loaded
[x] All tests pass