search

MichaelGrafnetter / DSInternals

Directory Services Internals (DSInternals) PowerShell Module and Framework
https://www.dsinternals.com
MIT License
1.65k stars 254 forks source link

Implement searching password hashes using split database #186

Open aseigler opened 1 month ago

aseigler commented 1 month ago

Resolves #185

aseigler commented 1 month ago

Old way:

PS R:\> (Measure-Command { $dsaccounts | Test-PasswordQuality -WeakPasswordHashesSortedFile R:\pwned.txt }).TotalMilliseconds
2141.1098

New way:

PS R:\> (Measure-Command { $dsaccounts | Test-PasswordQuality -WeakPasswordHashesSortedFilePath R:\hibp_files\ }).TotalMilliseconds
850.2169
MichaelGrafnetter commented 1 month ago

Hey @aseigler , thx for this nice PR. Could you please update the markdown documentation for the cmdlet as well, perhaps with an example? I am also not sure, if the command would work properly when both WeakPasswordHashesSortedFile and WeakPasswordHashesSortedFilePath are used.

aseigler commented 1 month ago

Hey @aseigler , thx for this nice PR. Could you please update the markdown documentation for the cmdlet as well, perhaps with an example?

Sure, no problem.

I am also not sure, if the command would work properly when both WeakPasswordHashesSortedFile and WeakPasswordHashesSortedFilePath are used.

This would definitely be an either/or situation, it would make no sense to try to do both in a single command, but checking for that case is simple enough as well.

aseigler commented 1 month ago

Ready for review again.

aseigler commented 2 weeks ago

Bump. @MichaelGrafnetter