MichaelGrupp / evo

Python package for the evaluation of odometry and SLAM
https://michaelgrupp.github.io/evo/
GNU General Public License v3.0
3.43k stars 746 forks source link

Is it a typo? #488

Closed zhangtao90 closed 2 years ago

zhangtao90 commented 2 years ago

In line 52 of evo/common_ape_rpe.py :

51 traj_ref = file_interface.read_euroc_csv_trajectory(args.state_gt_csv) 52 traj_est = file_interface.read_tum_trajectory_file(args.est_file) 53 ref_name, est_name = args.state_gt_csv, args.est_file

it should be read_euroc_csv_trajectory right?

I met error when using original code and make it work by replacing with read_euroc_csv_trajectory

MichaelGrupp commented 2 years ago

This is not a typo. The reason why it was written like this is because the euroc format is a ground truth data format. So the ground truth is in this euroc format, but the SLAM trajectory is in another format that makes sense. I chose the TUM data format as a convention. See also https://github.com/MichaelGrupp/evo/wiki/Formats#euroc---euroc-mav-dataset-format-also-used-in-tum-vi-dataset