search

MichaelGrupp / evo

Python package for the evaluation of odometry and SLAM
https://michaelgrupp.github.io/evo/
GNU General Public License v3.0
3.43k stars 746 forks source link

Ros Map masking - wiki typo #555

Closed JoLichtenfeld closed 1 year ago

JoLichtenfeld commented 1 year ago

Description: There seems to be a little error in the documentation of plotting, subsection 2D Ros maps / Masking. The proposed command to disable masking is evo_config set ros_map_unknown_cell_value false This sets the corresponding value to the string "false" which cannot be parsed by tools/plot.py . So the command should either be evo_config set ros_map_unknown_cell_value 0 or simply evo_config set ros_map_unknown_cell_value. The latter toggles the boolean state, so one would need to know the previous state.

MichaelGrupp commented 1 year ago

Thanks for the info.

The problem seems to be that the "false" gets saved as a string when setting it. The code could handle a boolean (here).

I will have a look how to improve this. Quick fix would be manually changing the json file and setting the value to false instead of "false". Value 0 doesn't truly deactivate it and could hide meaningful data depending on the map image representation.

MichaelGrupp commented 1 year ago

Edit: 0 does deactivate it right now, since it's implicitly boolean in this if-check. But this is probably also not good - I will take look later.

Probably the cleanest and easiest solution is to add just another bool parameter to enable and disable it that is independent of the numeric value.

MichaelGrupp commented 1 year ago

Added in v1.22.1, documentation is fixed. https://github.com/MichaelGrupp/evo/wiki/Plotting#masking