search

MichaelHatherly / CommonMark.jl

A CommonMark-compliant Markdown parser for Julia.
Other
87 stars 11 forks source link

autoidentifiers: Julia 1.0 compat, fix #33 #34

Closed fonsp closed 4 days ago

MichaelHatherly commented 2 years ago

Let's adjust CI to run on 1.0 - 1.2 as well here to ensure things are compatible with those versions.

I'd like to attempt to retain compat across 1.0 - latest if the maintenance burden isn't too high with needing to patch methods like this. I think we'll need a conditional definition here for get! such that it doesn't cause method overwrite warnings.

MichaelHatherly commented 2 years ago

There looks to be some other issues on 1.0-1.2 so I think it's simplest to just restrict compat for julia to 1.3 since that's what CI has been testing.

fonsp commented 2 years ago

I released MarkdownLiteral with julia = "1.3" :)

https://github.com/JuliaRegistries/General/pull/50958

MichaelHatherly commented 4 days ago

https://github.com/MichaelHatherly/CommonMark.jl/pull/76 changed the compat bounds, so this PR is not needed anymore.