MichaelHatherly / CommonMark.jl

A CommonMark-compliant Markdown parser for Julia.
Other
84 stars 11 forks source link

Migrate to PrecompileTools #64

Closed davidanthoff closed 1 year ago

davidanthoff commented 1 year ago

Would be great if this package could be migrated from SnoopPrecompile to PrecompileTools. For various reasons we can't ship packages that use SnoopPrecompile in the VS Code extension, but everything works fine with PrecompileTools. JuliaFormatter uses CommonMark, and so at the moment we are blocked from shipping the latest formatting code in the extension until CommonMark is also migrated to PrecompileTools. https://github.com/domluna/JuliaFormatter.jl/pull/710 has an example what needs to be done, I think it is fairly easy.

MichaelHatherly commented 1 year ago

Yeah, it's on the list of todos. Should be able to sort this today I'd think @davidanthoff.

MichaelHatherly commented 1 year ago

Will be included in https://github.com/JuliaRegistries/General/pull/82413.

davidanthoff commented 1 year ago

Hurray, thanks!