search

MichaelKim0407 / flake8-use-fstring

MIT License
51 stars 7 forks source link

feat: build and publish wheel #19

Closed wwuck closed 2 years ago

wwuck commented 2 years ago

build and publish a wheel in addition to sdist

MichaelKim0407 commented 2 years ago

Thanks for the PR.

However,

  1. I fail to see the benefits of building a wheel. From the documentation it looks like having a wheel in this case (pure Python) may only make the installation marginally faster (this is a pretty small library). Why do you want a wheel for this library?
  2. I wouldn't introduce a third-party tool to just build a wheel.
wwuck commented 2 years ago

No worries then. I'm happy to go without a wheel :)

MichaelKim0407 commented 2 years ago

Well I wasn't trying to shut you down, but I want to know if there is a practical reason you want to build a wheel.

wwuck commented 2 years ago

No particular reason, except I saw it wasn't there so I thought you might like to have one :)

https://github.com/pypa/build/ is the new recommended tool for building pep517 packages, in case you ever want to move this package in that direction.

I agree this is a pretty small package, so no real need to change anything at this point.