Closed dennis-tra closed 5 years ago
LGTM. Would you be able to update the tests and make them pass? Looks like just updating the mocks to simulate receiving the START message from a server.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
lib/src/remote_devtools_middleware.dart | 8 | 9 | 88.89% | ||
<!-- | Total: | 8 | 9 | 88.89% | --> |
Totals | |
---|---|
Change from base Build 85: | 0.9% |
Covered Lines: | 88 |
Relevant Lines: | 96 |
@MichaelMarner I updated the tests 👍
Awesome, thanks for the contribution!
This is now live in 0.0.9 on pub.dev
Perfect, thanks for merging :)
With this snippet I ran into a race condition
after the
await remoteDevtools.connect();
has resolved the connection is actually not yet established but it is in thestarting
state. The lead to my first dispatched actions not to appear in the Remote Dev Portal. The condition for forwarding actions isthis.status == RemoteDevToolsStatus.started
which was not the case yet.This pull request waits until the remote dev tools have responded with
START
and then resolves theconnect()
functions.