Closed dennis-tra closed 4 years ago
Totals | |
---|---|
Change from base Build 110: | 0.0% |
Covered Lines: | 92 |
Relevant Lines: | 100 |
Hey sorry for the delay getting to this. Thanks for the contribution! This looks good except should have a test case added to verify that the result of next
is returned from call.
Perhaps modify the existing test case:
To verify the returned value. Or make an additional test case.
But yes - this problem only exists because you don't have redux_thunks as the first middleware in your list. The Redux docs don't specify a requirement to return the result of calling next - and you are likely to run into problems with other middleware that also don't return values of calling next.
Essentially redux_thunk expects to be the first middleware.
Hey,
unfortunately redux_thunk actions are not working as with the normal redux store. With the
DevToolsStore
I'm not able to write code that awaits the result of a thunk action:I have already created a PR for the upstream redux_dev_tools package.
However there needs to be a tiny change in this package as well.
I managed to get it working locally when all changes from both repositories are applied.
As soon as the upstream changes are merged I'll update the
pubspec.yml
of this package as well and change remove the "Draft" status of this PR.EDIT: Now I'm wondering if this change here is only necessary because the
RemoteDevToolsMiddleware
is the first middleware in my chain. The second one is already thethunkmiddleware
... 🤔