search

MichaelMarner / dart-redux-remote-devtools

Remote Devtools for Dart & Flutter
https://pub.dartlang.org/packages/redux_remote_devtools
MIT License
52 stars 10 forks source link

Add support for "commit" action #28

Open zbarbuto opened 4 years ago

zbarbuto commented 4 years ago

The "commit" button in redux dev tools usually clears the action list and commits state.

image

However when clicking with Flutter we get "Unknown commans (sic): COMMIT. Ignoring"

image

MichaelMarner commented 4 years ago

What does "commit state" mean in this context? The action list is implemented entirely on the remote devtools server side - what is the flutter app supposed to do with the commit command?

MichaelMarner commented 4 years ago

Should devtools middleware dispatch a save action?

zbarbuto commented 4 years ago

That is probably the solution. I use the "commit" button to just clear the action log personally but the actual purpose of it is to save the current state for the "revert" button to jump to.

MichaelMarner commented 4 years ago

ok then it looks like devtools server is expecting a response back from us to indicate the commit occurred. I'll have a look into the source code and find out what we're supposed to send.