Update to redux devtools cli

MichaelMarner / dart-redux-remote-devtools

Remote Devtools for Dart & Flutter

https://pub.dartlang.org/packages/redux_remote_devtools

MIT License

52 stars 10 forks source link

Update to redux devtools cli #30

Closed nickmeinhold closed 1 year ago

nickmeinhold commented 4 years ago

Just the documentation changes for #29

app is currently not connecting to the server
created a draft PR and will look into why an app won't connect to the server if time permits

EDIT:

added notes to README on changing the settings in the Redux DevTools window so an app will connect
changed the PR from draft to "ready for review" as I won't keep looking into it for now because the redux devtools cli is working for me (although changing the settings isn't ideal)

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 135

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.308%

Totals
Change from base Build 132:	0.0%
Covered Lines:	84
Relevant Lines:	91

💛 - Coveralls

MichaelMarner commented 4 years ago

Hey just an update on this - it looks as though it is currently not possible to specify the host/port when starting devtools-cli - meaning you need to manually edit the connection settings after it is running. I think until that issue is resolved we'll hold off on merging this PR.

Not being able to specify the host/port from the command line leads to a poorer developer experience, IMO.

nickmeinhold commented 4 years ago

Thanks for the update @MichaelMarner. I think there are currently also some other problems with the redux-devtools-cli eg. I've noticed switching between Action and State while the app is running doesn't always update the Inspector's view. I will make an issue for that at some stage and report back. Thanks!

Methuselah96 commented 4 years ago

@MichaelMarner To be clear, the server is correctly started at the correct hostname and port, it's just that the Electron app that is opened doesn't automatically connect to that hostname and port.

You can also still go to http://localhost:8000 in your web browser (with or without the --open flag) if you prefer to do it that way, so I'm not sure that it's a poorer developer experience since you can still do it the old way without problems. (Or you can start it --open=browser and it will open the browser at the correct URL as well.) That being said, redux-devtools-cli is definitely still pre-release so no worries on holding off switching the documentation.

I'll look into automatically configuring the Electron app with the correct hostname and port when I get a chance.

@nickmeinhold Definitely would appreciate bug reports. Thanks for using it!